Page MenuHomePhabricator

Restrict movable panels to non-tab panels
ClosedPublic

Authored by chad on Feb 14 2017, 10:11 PM.
Tags
None
Referenced Files
F14082411: D17356.diff
Fri, Nov 22, 11:44 PM
Unknown Object (File)
Wed, Nov 20, 11:16 AM
Unknown Object (File)
Mon, Nov 18, 6:33 PM
Unknown Object (File)
Mon, Nov 18, 4:14 AM
Unknown Object (File)
Wed, Nov 13, 11:16 PM
Unknown Object (File)
Sun, Nov 10, 4:22 AM
Unknown Object (File)
Sat, Nov 9, 12:54 PM
Unknown Object (File)
Wed, Nov 6, 2:45 AM
Subscribers

Details

Summary

Fixes T12248. Adds a flag for movable panels, and only allows those to be moved. Also cleaned up some CSS rules missing once a panel was drug into a new position.

Test Plan

Try to drag a tab panel content pane, cannot. Drag normal pane, see CSS, grab and drag same panel back, CSS looks the same.

Diff Detail

Repository
rP Phabricator
Branch
drag-tab (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15633
Build 20634: Run Core Tests
Build 20633: arc lint + arc unit