Page MenuHomePhabricator

Use typeahead for tab panel selection
ClosedPublic

Authored by chad on Feb 14 2017, 9:34 PM.
Tags
None
Referenced Files
F15454491: D17355.id41735.diff
Sat, Mar 29, 6:46 PM
F15426951: D17355.id.diff
Sun, Mar 23, 11:47 AM
F15424073: D17355.diff
Sat, Mar 22, 8:03 PM
F15423682: D17355.id41735.diff
Sat, Mar 22, 4:40 PM
F15395496: D17355.id41736.diff
Sun, Mar 16, 7:22 AM
F15387445: D17355.id41736.diff
Sat, Mar 15, 2:25 AM
F15382030: D17355.diff
Fri, Mar 14, 10:24 AM
F15311738: D17355.id41735.diff
Thu, Mar 6, 10:34 AM
Subscribers

Details

Summary

Fixes T11449. Feels.... magical? Probably a more efficient way of doing this, but only 6 tabs so...

Test Plan

Create a tab panel in old UI. Edit panel in new UI. Create a panel in new UI, edit panel in new UI.

Diff Detail

Repository
rP Phabricator
Branch
tab-panel-typeahead (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15631
Build 20631: Run Core Tests
Build 20630: arc lint + arc unit

Event Timeline

chad retitled this revision from Use typeahead for tab panel selection. to Use typeahead for tab panel selection.Feb 14 2017, 9:38 PM
epriestley added inline comments.
src/applications/dashboard/customfield/PhabricatorDashboardPanelTabsCustomField.php
38–39

LUL

This revision is now accepted and ready to land.Feb 14 2017, 9:40 PM

If we could get away with not naming tabs, this entire interface is just a tokenizer.

This revision was automatically updated to reflect the committed changes.