Page MenuHomePhabricator

Use typeahead for tab panel selection
ClosedPublic

Authored by chad on Feb 14 2017, 9:34 PM.

Details

Summary

Fixes T11449. Feels.... magical? Probably a more efficient way of doing this, but only 6 tabs so...

Test Plan

Create a tab panel in old UI. Edit panel in new UI. Create a panel in new UI, edit panel in new UI.

Diff Detail

Repository
rP Phabricator
Branch
tab-panel-typeahead (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15631
Build 20631: Run Core Tests
Build 20630: arc lint + arc unit

Event Timeline

chad retitled this revision from Use typeahead for tab panel selection. to Use typeahead for tab panel selection.Feb 14 2017, 9:38 PM
epriestley added inline comments.
src/applications/dashboard/customfield/PhabricatorDashboardPanelTabsCustomField.php
38–39

LUL

This revision is now accepted and ready to land.Feb 14 2017, 9:40 PM

If we could get away with not naming tabs, this entire interface is just a tokenizer.

This revision was automatically updated to reflect the committed changes.