Differential D17355

Use typeahead for tab panel selection
ClosedPublic
Actions

Authored by chad on Feb 14 2017, 9:34 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T11449: Selecting tabs for a Dashboard tab panel uses a plain <select /> which is a big mess

Commits

rPb28b2b8ab87c: Use typeahead for tab panel selection

Summary

Fixes T11449. Feels.... magical? Probably a more efficient way of doing this, but only 6 tabs so...

Test Plan

Create a tab panel in old UI. Edit panel in new UI. Create a panel in new UI, edit panel in new UI.

Diff Detail

Repository

rP Phabricator

Branch

tab-panel-typeahead (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15631
Build 20631: Run Core Tests
Build 20630: arc lint + arc unit

Event Timeline

chad created this revision.Feb 14 2017, 9:34 PM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 14 2017, 9:34 PM

Harbormaster completed remote builds in B15631: Diff 41735.Feb 14 2017, 9:35 PM

chad retitled this revision from Use typeahead for tab panel selection. to Use typeahead for tab panel selection.Feb 14 2017, 9:38 PM

epriestley accepted this revision.Feb 14 2017, 9:40 PM

epriestley added inline comments.

src/applications/dashboard/customfield/PhabricatorDashboardPanelTabsCustomField.php
38–39	LUL

This revision is now accepted and ready to land.Feb 14 2017, 9:40 PM

If we could get away with not naming tabs, this entire interface is just a tokenizer.

BUT 12 FIELDS IT IS

Closed by commit rPb28b2b8ab87c: Use typeahead for tab panel selection (authored by chad, committed by chad). · Explain WhyFeb 14 2017, 9:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

customfield/

PhabricatorDashboardPanelTabsCustomField.php

34 lines

Diff 41735

View Options

src/applications/dashboard/customfield/PhabricatorDashboardPanelTabsCustomField.php

Use typeahead for tab panel selectionClosedPublicActions