Page MenuHomePhabricator

Fix an issue where resolveKill() emits a warning if the future was never started
ClosedPublic

Authored by epriestley on Feb 14 2017, 3:17 PM.
Tags
None
Referenced Files
F15417312: D17354.id41731.diff
Thu, Mar 20, 4:36 PM
F15412216: D17354.id41734.diff
Wed, Mar 19, 11:50 AM
F15396987: D17354.diff
Sun, Mar 16, 5:24 PM
F15380382: D17354.id41734.diff
Fri, Mar 14, 2:47 AM
F15369742: D17354.diff
Wed, Mar 12, 8:03 AM
Unknown Object (File)
Sun, Mar 2, 3:33 AM
Unknown Object (File)
Feb 21 2025, 3:10 PM
Unknown Object (File)
Feb 16 2025, 9:29 PM
Subscribers
None

Details

Summary

Ref T2794. This is a minor warning I hit while exploring Phage stuff. In Phage, we can resolveKill() a future that we never called start() on, which tries to proc_terminate() a process which never spawned. This emits a warning.

Instead, check that $this->proc exists before signaling it.

Test Plan

Added a unit test.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable