Page MenuHomePhabricator

Fix an issue where resolveKill() emits a warning if the future was never started
ClosedPublic

Authored by epriestley on Feb 14 2017, 3:17 PM.
Tags
None
Referenced Files
F13179628: D17354.diff
Wed, May 8, 9:19 PM
Unknown Object (File)
Tue, May 7, 3:15 PM
Unknown Object (File)
Sat, May 4, 6:54 PM
Unknown Object (File)
Tue, Apr 30, 10:19 PM
Unknown Object (File)
Tue, Apr 23, 9:11 PM
Unknown Object (File)
Tue, Apr 23, 9:11 PM
Unknown Object (File)
Tue, Apr 23, 9:11 PM
Unknown Object (File)
Tue, Apr 23, 9:11 PM
Subscribers
None

Details

Summary

Ref T2794. This is a minor warning I hit while exploring Phage stuff. In Phage, we can resolveKill() a future that we never called start() on, which tries to proc_terminate() a process which never spawned. This emits a warning.

Instead, check that $this->proc exists before signaling it.

Test Plan

Added a unit test.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable