Page MenuHomePhabricator

Fix an issue where resolveKill() emits a warning if the future was never started
ClosedPublic

Authored by epriestley on Feb 14 2017, 3:17 PM.
Tags
None
Referenced Files
F15471795: D17354.id41734.diff
Sat, Apr 5, 8:08 AM
F15470595: D17354.id41731.diff
Fri, Apr 4, 11:37 PM
F15467247: D17354.id41734.diff
Thu, Apr 3, 1:51 PM
F15460316: D17354.id41731.diff
Mon, Mar 31, 9:55 PM
F15459108: D17354.id41734.diff
Mon, Mar 31, 9:55 AM
F15457836: D17354.id.diff
Sun, Mar 30, 7:18 PM
F15457211: D17354.id41734.diff
Sun, Mar 30, 2:59 PM
F15455326: D17354.diff
Sat, Mar 29, 11:32 PM
Subscribers
None

Details

Summary

Ref T2794. This is a minor warning I hit while exploring Phage stuff. In Phage, we can resolveKill() a future that we never called start() on, which tries to proc_terminate() a process which never spawned. This emits a warning.

Instead, check that $this->proc exists before signaling it.

Test Plan

Added a unit test.

Diff Detail

Repository
rPHU libphutil
Branch
phage1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15627
Build 20626: Run Core Tests
Build 20625: arc lint + arc unit