Page MenuHomePhabricator

Fix an issue where resolveKill() emits a warning if the future was never started
ClosedPublic

Authored by epriestley on Feb 14 2017, 3:17 PM.
Tags
None
Referenced Files
F18816147: D17354.id.diff
Oct 21 2025, 5:10 AM
F18778832: D17354.id41734.diff
Oct 11 2025, 11:01 AM
F18693067: D17354.diff
Sep 27 2025, 12:06 AM
F18679429: D17354.diff
Sep 26 2025, 12:50 AM
F18679317: D17354.diff
Sep 26 2025, 12:42 AM
F18610587: D17354.diff
Sep 14 2025, 5:07 AM
F18508517: D17354.id.diff
Sep 5 2025, 2:51 AM
F18500588: D17354.diff
Sep 4 2025, 9:10 PM
Subscribers
None

Details

Summary

Ref T2794. This is a minor warning I hit while exploring Phage stuff. In Phage, we can resolveKill() a future that we never called start() on, which tries to proc_terminate() a process which never spawned. This emits a warning.

Instead, check that $this->proc exists before signaling it.

Test Plan

Added a unit test.

Diff Detail

Repository
rPHU libphutil
Branch
phage1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15627
Build 20626: Run Core Tests
Build 20625: arc lint + arc unit