Page MenuHomePhabricator
Differential D17349

Fix duplicating panel when editing in column 2
ClosedPublic
Actions

Authored by chad on Feb 14 2017, 2:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 10:34 AM
Unknown Object (File)
Sat, Apr 27, 2:54 AM
Unknown Object (File)
Tue, Apr 23, 9:10 PM
Unknown Object (File)
Tue, Apr 23, 9:10 PM
Unknown Object (File)
Tue, Apr 23, 9:10 PM
Unknown Object (File)
Tue, Apr 23, 9:10 PM
Unknown Object (File)
Tue, Apr 23, 4:56 PM
Unknown Object (File)
Fri, Apr 19, 2:33 AM
View All Files
Subscribers
Korvin
Tokens
"Mountain of Wealth" token, awarded by allixsenos."Haypence" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T10612: Editing a panel causes it to duplicate in dashboard
Commits
rP1cb924ce68ba: Fix duplicating panel when editing in column 2
Summary

Fixes T10612. We're writing a new panel to any dashboard even if it already exists. No need when just updating a panel title.

Test Plan

Add "welcome" panel to column 2 of a clean dashboard. Edit title, save. See correct panel in correct place.

Diff Detail

Repository
rP Phabricator
Branch
dupe-panel-edit (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15621
Build 20616: Run Core Tests
Build 20615: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
dashboard/
controller/
2 lines

Diff 41722

View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php

Loading...
Phabricator · Built by Phacility