Fix flipped open/closed status for Diviner atoms in search index
ClosedPublic
Actions

Authored by epriestley on Feb 13 2017, 9:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 12, 11:14 PM

	Unknown Object (File)
	Mon, Dec 9, 5:34 PM

	Unknown Object (File)
	Sun, Dec 8, 4:02 PM

	Unknown Object (File)
	Fri, Dec 6, 3:56 AM

	Unknown Object (File)
	Mon, Dec 2, 4:19 PM

	Unknown Object (File)
	Thu, Nov 28, 1:07 AM

	Unknown Object (File)
	Nov 24 2024, 1:58 AM

	Unknown Object (File)
	Oct 31 2024, 12:11 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12258: Diviner atom document status inverted when searching

Commits

rP6f37685a7589: Fix flipped open/closed status for Diviner atoms in search index

Summary

Fixes T12258. I think these constants are just flipped.

Test Plan

Kinda winged it.

Diff Detail

Repository

rP Phabricator

Branch

diviner1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15615
Build 20607: Run Core Tests
Build 20606: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2017, 9:07 PM

Harbormaster completed remote builds in B15615: Diff 41717.Feb 13 2017, 9:08 PM

chad accepted this revision.Feb 13 2017, 9:10 PM

This revision is now accepted and ready to land.Feb 13 2017, 9:10 PM

Closed by commit rP6f37685a7589: Fix flipped open/closed status for Diviner atoms in search index (authored by epriestley, committed by epriestley). · Explain WhyFeb 13 2017, 9:12 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12258: Diviner atom document status inverted when searching.Feb 14 2017, 12:05 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

search/

DivinerLiveSymbolFulltextEngine.php

4 lines

Diff 41717

View Options

src/applications/diviner/search/DivinerLiveSymbolFulltextEngine.php

Fix flipped open/closed status for Diviner atoms in search indexClosedPublicActions