Differential D17333

Don't try to access the Stripe object until the user submits the credit card form
ClosedPublic
Actions

Authored by epriestley on Feb 10 2017, 4:35 PM.

Details

Reviewers

chad

Maniphest Tasks

T12232: Phortune "add payment method" erroring out on submission

Commits

rP4039f5f11b71: Don't try to access the Stripe object until the user submits the credit card…

Summary

Ref T12232. I can't reproduce the original issue, but this should probably fix it without side effects?

Test Plan

Added a card with Stripe, but I could do that before too.

Diff Detail

Repository

rP Phabricator

Branch

stripe1

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	webroot/rsrc/js/application/phortune/behavior-stripe-payment-form.js:13	W117	JSHintW117

Unit

No Test Coverage

Build Status

Buildable 15584
Build 20562: Run Core Tests
Build 20561: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 10 2017, 4:35 PM

chad accepted this revision.Feb 10 2017, 4:35 PM

This revision is now accepted and ready to land.Feb 10 2017, 4:35 PM

Closed by commit rP4039f5f11b71: Don't try to access the Stripe object until the user submits the credit card… (authored by epriestley, committed by epriestley). · Explain WhyFeb 10 2017, 4:40 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12232: Phortune "add payment method" erroring out on submission.Feb 10 2017, 4:44 PM

epriestley mentioned this in T12307: Users unable to add new credit cards to Autopay?.Feb 22 2017, 12:41 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

14 lines

webroot/

rsrc/

js/

application/

phortune/

behavior-stripe-payment-form.js

3 lines

Diff 41687

View Options

resources/celerity/map.php