Page MenuHomePhabricator
Differential D17317

Clarify that "account.editable" no longer extends to profile pictures
ClosedPublic
Actions

Authored by epriestley on Feb 6 2017, 1:02 PM.
Tags
None
Referenced Files
F13198343: D17317.id41646.diff
Mon, May 13, 5:50 AM
F13189427: D17317.diff
Sat, May 11, 5:56 AM
Unknown Object (File)
Tue, May 7, 9:42 AM
Unknown Object (File)
Fri, May 3, 5:29 AM
Unknown Object (File)
Fri, Apr 26, 1:04 AM
Unknown Object (File)
Apr 11 2024, 10:28 AM
Unknown Object (File)
Apr 10 2024, 1:21 AM
Unknown Object (File)
Apr 10 2024, 12:39 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12216: User can change userpic when account.editable is false (bad config description or restrictions mistake)
Commits
rP3d44208e4f65: Clarify that "account.editable" no longer extends to profile pictures
Summary

Fixes T12216. I'd like to remove this option eventually, but just narrow its scope in the config description for now.

Test Plan

Read config description.

Diff Detail

Repository
rP Phabricator
Branch
editable1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15548
Build 20505: Run Core Tests
Build 20504: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 6 2017, 1:02 PM
Harbormaster completed remote builds in B15548: Diff 41646.Feb 6 2017, 1:03 PM
chad accepted this revision.Feb 6 2017, 3:32 PM
This revision is now accepted and ready to land.Feb 6 2017, 3:32 PM
Closed by commit rP3d44208e4f65: Clarify that "account.editable" no longer extends to profile pictures (authored by epriestley, committed by epriestley). · Explain WhyFeb 6 2017, 4:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
option/
12 lines

Diff 41646

View Options

src/applications/config/option/PhabricatorAuthenticationConfigOptions.php

Loading...
Phabricator · Built by Phacility