Page MenuHomePhabricator

Remove bad "Session" link in User activity logs
ClosedPublic

Authored by epriestley on Feb 6 2017, 12:30 PM.
Tags
None
Referenced Files
F19093132: D17316.diff
Dec 3 2025, 7:51 PM
F19062894: D17316.id.diff
Nov 29 2025, 4:56 PM
F19046128: D17316.diff
Nov 27 2025, 9:36 AM
F18778522: D17316.id.diff
Oct 11 2025, 9:48 AM
F18757157: D17316.diff
Oct 5 2025, 3:47 PM
F18733456: D17316.id.diff
Sep 30 2025, 10:34 PM
F18094334: D17316.diff
Aug 7 2025, 10:04 PM
F18092518: D17316.id41645.diff
Aug 7 2025, 11:03 AM
Subscribers
None

Details

Summary

Fixes T12215. Two issues:

  • We build this $session link out of $ip, which is (a) wrong even if $ip was the IP and (b) super wrong since $ip is a tag.
  • These links don't work even if we'd built them right: searching by the prefix of a session identifier does nothing.

At least for now, just get rid of the links rather than trying to make this behavior work.

Test Plan

On People > Activity logs:

  • Before patch: Saw bad links with bogus targets in "session" column.
  • After patch: Saw plain text in "session" column.

Diff Detail

Repository
rP Phabricator
Branch
session1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15547
Build 20503: Run Core Tests
Build 20502: arc lint + arc unit