Page MenuHomePhabricator

Remove bad "Session" link in User activity logs
ClosedPublic

Authored by epriestley on Feb 6 2017, 12:30 PM.
Tags
None
Referenced Files
F15341261: D17316.id41645.diff
Sun, Mar 9, 7:23 PM
Unknown Object (File)
Sat, Mar 1, 8:30 PM
Unknown Object (File)
Feb 9 2025, 3:13 AM
Unknown Object (File)
Feb 9 2025, 3:13 AM
Unknown Object (File)
Feb 9 2025, 3:13 AM
Unknown Object (File)
Feb 9 2025, 3:13 AM
Unknown Object (File)
Jan 28 2025, 7:47 AM
Unknown Object (File)
Jan 27 2025, 3:33 AM
Subscribers
None

Details

Summary

Fixes T12215. Two issues:

  • We build this $session link out of $ip, which is (a) wrong even if $ip was the IP and (b) super wrong since $ip is a tag.
  • These links don't work even if we'd built them right: searching by the prefix of a session identifier does nothing.

At least for now, just get rid of the links rather than trying to make this behavior work.

Test Plan

On People > Activity logs:

  • Before patch: Saw bad links with bogus targets in "session" column.
  • After patch: Saw plain text in "session" column.

Diff Detail

Repository
rP Phabricator
Branch
session1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15547
Build 20503: Run Core Tests
Build 20502: arc lint + arc unit