Page MenuHomePhabricator
Differential D17309

Update Profile Menu diviner
ClosedPublic
Actions

Authored by chad on Feb 3 2017, 10:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 5:40 PM
Unknown Object (File)
Sat, Dec 14, 8:16 AM
Unknown Object (File)
Mon, Dec 9, 9:34 AM
Unknown Object (File)
Mon, Dec 9, 9:34 AM
Unknown Object (File)
Mon, Dec 9, 9:34 AM
Unknown Object (File)
Mon, Dec 9, 9:33 AM
Unknown Object (File)
Sun, Dec 8, 7:30 AM
Unknown Object (File)
Mon, Dec 2, 9:07 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12174: Home Menu Errata
Commits
rPc8de563622cb: Update Profile Menu diviner
Summary

Ref T12174, Updates documentation to better match current functionality.

Test Plan

I keep getting exceptions trying to generate diviner locally, not sure what's up.

Diff Detail

Repository
rP Phabricator
Branch
diviner-profile-menu (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15527
Build 20475: Run Core Tests
Build 20474: arc lint + arc unit

Event Timeline

chad created this revision.Feb 3 2017, 10:22 PM
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 3 2017, 10:22 PM
Harbormaster completed remote builds in B15527: Diff 41630.Feb 3 2017, 10:23 PM
chad added a comment.Feb 3 2017, 10:24 PM
BUILDING GRAPH CACHE
Found 6,914 obsolete atoms in graph.
Found 8,932 new atoms in graph.
Propagating changes through the graph.
[2017-02-03 22:23:45] ERROR 8: unserialize(): Error at offset 185 of 907 bytes at [/var/www/html/dev/core/lib/libphutil/src/cache/PhutilDirectoryKeyValueCache.php:58]
arcanist(head=master, ref.master=ade25facfdf2), corgi(head=master, ref.master=aebec8206183), instances(head=master, ref.master=0ddfd7990f6e), libcore(), phabricator(head=diviner-profile-menu, ref.master=42743810e914, ref.diviner-profile-menu=8eb10f48320e), phutil(head=master, ref.master=9d85dfab0f53), services(head=master, ref.master=b5cef1ac31ff)
  #0 unserialize(string) called at [<phutil>/src/cache/PhutilDirectoryKeyValueCache.php:58]
  #1 PhutilDirectoryKeyValueCache::getKeys(array) called at [<phutil>/src/cache/PhutilKeyValueCacheProxy.php:21]
epriestley accepted this revision.Feb 4 2017, 12:39 AM

Blanket fix that might resolve the unserialize() is to try bin/diviner generate --clean, although that takes quite a while.

(I get some different weirdness running diviner generate locally, maybe a PHP 7 issue? Did you stay on PHP7 or drop back to PHP5? I don't see the unserialize issue, though.)

If that doesn't work you can also just like copy/paste the whole document into a task or comment and look at the preview, which is 95% accurate and good enough to catch stuff like misspelled {icon} or whatever.

src/docs/user/userguide/profile_menu.diviner
131

"Let's" -> "Lets": not "Let us you..."

132

"purely" -> "Purely" (beginning of sentence)

This revision is now accepted and ready to land.Feb 4 2017, 12:39 AM
chad added a comment.Feb 4 2017, 1:47 AM

it's still building

Closed by commit rPc8de563622cb: Update Profile Menu diviner (authored by chad, committed by chad). · Explain WhyFeb 4 2017, 2:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
docs/
user/
userguide/
48 lines

Diff 41630

View Options

src/docs/user/userguide/profile_menu.diviner

Loading...
Phabricator · Built by Phacility