Paths

Table of Contentst

Differential D17297

Fix a mismatched method definition in PhabricatorHomeProfileMenuItem
ClosedPublic
Actions

Authored by epriestley on Feb 2 2017, 2:03 PM.

Tags

None

Referenced Files

	F14094503: D17297.id41604.diff
	Mon, Nov 25, 3:59 PM

	F14092626: D17297.diff
	Mon, Nov 25, 7:10 AM

	Unknown Object (File)
	Oct 22 2024, 11:32 PM

	Unknown Object (File)
	Oct 17 2024, 10:02 PM

	Unknown Object (File)
	Oct 13 2024, 7:49 AM

	Unknown Object (File)
	Oct 9 2024, 7:42 PM

	Unknown Object (File)
	Oct 2 2024, 11:54 AM

	Unknown Object (File)
	Sep 30 2024, 3:02 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12187: Editing Menu Items leads into daemon or transaction errors
T12190: In PHP7, include-time warnings from source files are ignored

Commits

rPd0258a898175: Fix a mismatched method definition in PhabricatorHomeProfileMenuItem

Summary

Fixes T12187. Ref T12190. See T12190 for discussion of why this escaped notice.

Test Plan

Commented out the error_reporting() clause around file inclusion.
Reproduced the error in PHP7.
Corrected the method signature.
Reloaded the page, no more error.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 2 2017, 2:03 PM

Harbormaster completed remote builds in B15501: Diff 41603.Feb 2 2017, 2:04 PM

OCram mentioned this in Z1336: General Chat.Feb 2 2017, 2:09 PM

chad accepted this revision.Feb 2 2017, 2:53 PM

This revision is now accepted and ready to land.Feb 2 2017, 2:53 PM

Closed by commit rPd0258a898175: Fix a mismatched method definition in PhabricatorHomeProfileMenuItem (authored by epriestley, committed by epriestley). · Explain WhyFeb 2 2017, 3:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

home/

menuitem/

PhabricatorHomeProfileMenuItem.php

3 lines

Diff 41604

src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php

Loading...