Page MenuHomePhabricator
Differential D17288

Show magic "Home" menu item for logged-out users on public installs
ClosedPublic
Actions

Authored by epriestley on Feb 1 2017, 5:57 PM.
Tags
None
Referenced Files
F14401930: D17288.id41587.diff
Sun, Dec 22, 11:09 PM
F14399722: D17288.diff
Sun, Dec 22, 5:41 PM
Unknown Object (File)
Thu, Dec 19, 8:05 PM
Unknown Object (File)
Tue, Dec 3, 8:17 PM
Unknown Object (File)
Mon, Dec 2, 5:48 AM
Unknown Object (File)
Tue, Nov 26, 10:51 PM
Unknown Object (File)
Sun, Nov 24, 8:30 AM
Unknown Object (File)
Nov 22 2024, 8:23 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12174: Home Menu Errata
Commits
rP3fc03c0da106: Show magic "Home" menu item for logged-out users on public installs
Summary

Ref T12174. Setup is:

  • Allow public access.
  • Don't touch the default menu.
  • Visit / while logged out.

Currently, you see "magic home" as content, but don't actually see the menu item.

Instead, show the menu item.

Test Plan

Screen Shot 2017-02-01 at 9.55.39 AM.png (870×1 px, 202 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 1 2017, 5:57 PM
Harbormaster completed remote builds in B15485: Diff 41587.Feb 1 2017, 5:57 PM
Harbormaster completed remote builds in B15485: Diff 41587.
chad accepted this revision.Feb 1 2017, 6:03 PM
This revision is now accepted and ready to land.Feb 1 2017, 6:03 PM
Closed by commit rP3fc03c0da106: Show magic "Home" menu item for logged-out users on public installs (authored by epriestley, committed by epriestley). · Explain WhyFeb 1 2017, 6:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
home/
menuitem/
4 lines

Diff 41590

View Options

src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php

Loading...
Phabricator · Built by Phacility