Use a label for default home menu
ClosedPublic
Actions

Authored by chad on Feb 1 2017, 6:17 AM.

Tags

None

Referenced Files

	F15460172: D17287.id41582.diff
	Mon, Mar 31, 8:46 PM

	F15459213: D17287.id41583.diff
	Mon, Mar 31, 11:01 AM

	F15458940: D17287.diff
	Mon, Mar 31, 8:28 AM

	F15457247: D17287.id.diff
	Sun, Mar 30, 3:10 PM

	F15455194: D17287.diff
	Sat, Mar 29, 10:48 PM

	F15434368: D17287.id41582.diff
	Tue, Mar 25, 3:11 AM

	F15426368: D17287.diff
	Sun, Mar 23, 8:16 AM

	F15389691: D17287.id41583.diff
	Sat, Mar 15, 5:34 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12174: Home Menu Errata

Commits

rPf4dbe6330af2: Use a label for default home menu

Summary

Ref T12174, I think this feels slightly nicer having "Applications"

Test Plan

Review home changes

Diff Detail

Repository

rP Phabricator

Branch

built-home (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15480
Build 20404: Run Core Tests
Build 20403: arc lint + arc unit

Event Timeline

chad created this revision.Feb 1 2017, 6:17 AM

Harbormaster completed remote builds in B15480: Diff 41582.Feb 1 2017, 6:17 AM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 1 2017, 6:17 AM

Harbormaster completed remote builds in B15480: Diff 41582.Feb 1 2017, 6:18 AM

epriestley accepted this revision.Feb 1 2017, 1:29 PM

This revision is now accepted and ready to land.Feb 1 2017, 1:29 PM

Closed by commit rPf4dbe6330af2: Use a label for default home menu (authored by chad, committed by chad). · Explain WhyFeb 1 2017, 3:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

home/

constants/

PhabricatorHomeConstants.php

1 line

engine/

PhabricatorHomeProfileMenuEngine.php

11 lines

Diff 41582

View Options

src/applications/home/constants/PhabricatorHomeConstants.php