Use a label for default home menu
ClosedPublic
Actions

Authored by chad on Feb 1 2017, 6:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Feb 20, 1:40 AM

	Unknown Object (File)
	Sun, Feb 16, 1:06 PM

	Unknown Object (File)
	Fri, Jan 31, 9:57 PM

	Unknown Object (File)
	Tue, Jan 28, 8:52 AM

	Unknown Object (File)
	Sat, Jan 25, 3:29 PM

	Unknown Object (File)
	Thu, Jan 23, 11:02 AM

	Unknown Object (File)
	Thu, Jan 23, 8:53 AM

	Unknown Object (File)
	Jan 21 2025, 8:40 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12174: Home Menu Errata

Commits

rPf4dbe6330af2: Use a label for default home menu

Summary

Ref T12174, I think this feels slightly nicer having "Applications"

Test Plan

Review home changes

Diff Detail

Repository

rP Phabricator

Branch

built-home (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15480
Build 20404: Run Core Tests
Build 20403: arc lint + arc unit

Event Timeline

chad created this revision.Feb 1 2017, 6:17 AM

Harbormaster completed remote builds in B15480: Diff 41582.Feb 1 2017, 6:17 AM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 1 2017, 6:17 AM

Harbormaster completed remote builds in B15480: Diff 41582.Feb 1 2017, 6:18 AM

epriestley accepted this revision.Feb 1 2017, 1:29 PM

This revision is now accepted and ready to land.Feb 1 2017, 1:29 PM

Closed by commit rPf4dbe6330af2: Use a label for default home menu (authored by chad, committed by chad). · Explain WhyFeb 1 2017, 3:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

home/

constants/

PhabricatorHomeConstants.php

1 line

engine/

PhabricatorHomeProfileMenuEngine.php

11 lines

Diff 41582

View Options

src/applications/home/constants/PhabricatorHomeConstants.php