Improve page titles for menu items that render in-context content
ClosedPublic
Actions

Authored by epriestley on Jan 31 2017, 9:30 PM.

Tags

None

Referenced Files

	F13139088: D17281.diff
	Fri, May 3, 2:30 AM

	F13134777: D17281.diff
	Thu, May 2, 5:08 AM

	Unknown Object (File)
	Wed, May 1, 8:46 PM

	Unknown Object (File)
	Wed, May 1, 1:43 PM

	Unknown Object (File)
	Mon, Apr 29, 2:02 PM

	Unknown Object (File)
	Fri, Apr 26, 2:28 AM

	Unknown Object (File)
	Wed, Apr 24, 10:07 PM

	Unknown Object (File)
	Sun, Apr 21, 4:15 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12174: Home Menu Errata

Commits

rPe8c575819243: Improve page titles for menu items that render in-context content

Summary

Ref T12174. Dashboards and "Home" currently use the page title "Configure Menu". Give them more appropriate titles instead.

Test Plan

Viewed dashboards, Home. Saw relevant page titles.

Diff Detail

Repository

rP Phabricator

Branch

home7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15467
Build 20384: Run Core Tests
Build 20383: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 31 2017, 9:30 PM

Harbormaster completed remote builds in B15467: Diff 41569.Jan 31 2017, 9:31 PM

chad accepted this revision.Jan 31 2017, 9:35 PM

This revision is now accepted and ready to land.Jan 31 2017, 9:35 PM

Closed by commit rPe8c575819243: Improve page titles for menu items that render in-context content (authored by epriestley, committed by epriestley). · Explain WhyJan 31 2017, 9:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorProfileMenuEngine.php

7 lines

Diff 41569

View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Improve page titles for menu items that render in-context contentClosedPublicActions