Allow menu items to render their own content; make Dashboard items render on-page
ClosedPublic
Actions

Authored by epriestley on Jan 26 2017, 8:53 PM.

Details

Reviewers

chad

Maniphest Tasks

T11957: Add MenuEngine to Home

Commits

rP2dc4692021c3: (stable) Allow menu items to render their own content; make Dashboard items…
rP5960b1c8a3cd: Allow menu items to render their own content; make Dashboard items render on…

Summary

Ref T11957. When you click a dashboard item, it now sends you to /<app>/item/view/123/, which renders the proper crumbs, navigation, etc., with the dashboard as page content.

This works as you'd expect in Projects:

Screen Shot 2017-01-26 at 12.09.24 PM.png (1×1 px, 449 KB)

It's sliiiightly odd in Favorites since we nuke the nav menu, but seems basically fine?

Screen Shot 2017-01-26 at 12.13.50 PM.png (951×1 px, 127 KB)

Test Plan

Created a dashboard panel on a project.
Clicked it, saw it render.
Made it the default panel, viewed project default screen, saw dashboard.
Disabled every panel I could, still saw reasonable behavior (this is silly anyway).

Diff Detail

Repository

rP Phabricator

Branch

dash1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/search/engine/PhabricatorProfileMenuEngine.php:174	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 15388
Build 20269: Run Core Tests
Build 20268: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 26 2017, 8:53 PM

Harbormaster completed remote builds in B15388: Diff 41506.Jan 26 2017, 8:54 PM

chad accepted this revision.Jan 26 2017, 8:55 PM

This revision is now accepted and ready to land.Jan 26 2017, 8:55 PM

I'm only like 85% confident this actually works right but I couldn't break it and I tried a lot of stuff. Definitely could have missed some edge cases, though.

Closed by commit rP5960b1c8a3cd: Allow menu items to render their own content; make Dashboard items render on… (authored by epriestley, committed by epriestley). · Explain WhyJan 26 2017, 8:57 PM

This revision was automatically updated to reflect the committed changes.