Page MenuHomePhabricator

Add a "Needs Verification" state to Audit
ClosedPublic

Authored by epriestley on Jan 25 2017, 8:21 PM.
Tags
None
Referenced Files
F19945330: D17252.diff
Thu, Apr 16, 4:59 PM
F19889243: D17252.id.diff
Tue, Mar 24, 10:25 AM
F19869005: D17252.diff
Mar 15 2026, 4:50 AM
F19814315: D17252.diff
Mar 4 2026, 1:32 PM
F19800528: D17252.id.diff
Feb 28 2026, 4:06 PM
F19607673: D17252.id.diff
Feb 3 2026, 11:54 AM
F19561748: D17252.diff
Jan 31 2026, 11:23 AM
F19051717: D17252.diff
Nov 28 2025, 1:36 AM
Subscribers
None

Details

Summary

Fixes T2393. This allows authors to explicitly say "I think I fixed everything, please accept my commit now thank you".

Also improves behavior of "re-accept" and "re-reject" after new auditors you have authority over get added.

Test Plan
  • Kicked a commit back and forth between an author and auditor by alternately using "Request Verification" and "Raise Concern".
  • Verified it showed up properly in bucketing for both users.
  • Accepted, added a project, accepted again (works now; didn't before).
  • Audited on behalf of projects / packages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable