Page MenuHomePhabricator

Add a "Needs Verification" state to Audit
ClosedPublic

Authored by epriestley on Jan 25 2017, 8:21 PM.
Tags
None
Referenced Files
F18832200: D17252.diff
Sat, Oct 25, 8:07 PM
F18792995: D17252.diff
Thu, Oct 16, 8:35 PM
F18761012: D17252.id41489.diff
Mon, Oct 6, 11:55 AM
F18710023: D17252.diff
Mon, Sep 29, 1:18 AM
F18670158: D17252.id41494.diff
Sep 24 2025, 11:17 PM
F18591849: D17252.diff
Sep 12 2025, 10:17 AM
F18508449: D17252.id.diff
Sep 5 2025, 2:49 AM
F18500514: D17252.diff
Sep 4 2025, 9:07 PM
Subscribers
None

Details

Summary

Fixes T2393. This allows authors to explicitly say "I think I fixed everything, please accept my commit now thank you".

Also improves behavior of "re-accept" and "re-reject" after new auditors you have authority over get added.

Test Plan
  • Kicked a commit back and forth between an author and auditor by alternately using "Request Verification" and "Raise Concern".
  • Verified it showed up properly in bucketing for both users.
  • Accepted, added a project, accepted again (works now; didn't before).
  • Audited on behalf of projects / packages.

Diff Detail

Repository
rP Phabricator
Branch
audit4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15379
Build 20257: Run Core Tests
Build 20256: arc lint + arc unit