Page MenuHomePhabricator

Add a "Needs Verification" state to Audit
ClosedPublic

Authored by epriestley on Jan 25 2017, 8:21 PM.
Tags
None
Referenced Files
F13207492: D17252.id41489.diff
Thu, May 16, 12:23 AM
F13205467: D17252.diff
Wed, May 15, 1:58 AM
F13189116: D17252.diff
Sat, May 11, 5:44 AM
Unknown Object (File)
Tue, May 7, 9:27 AM
Unknown Object (File)
Fri, May 3, 9:18 AM
Unknown Object (File)
Thu, May 2, 1:23 PM
Unknown Object (File)
Wed, May 1, 10:44 PM
Unknown Object (File)
Thu, Apr 25, 2:54 AM
Subscribers
None

Details

Summary

Fixes T2393. This allows authors to explicitly say "I think I fixed everything, please accept my commit now thank you".

Also improves behavior of "re-accept" and "re-reject" after new auditors you have authority over get added.

Test Plan
  • Kicked a commit back and forth between an author and auditor by alternately using "Request Verification" and "Raise Concern".
  • Verified it showed up properly in bucketing for both users.
  • Accepted, added a project, accepted again (works now; didn't before).
  • Audited on behalf of projects / packages.

Diff Detail

Repository
rP Phabricator
Branch
audit4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15379
Build 20257: Run Core Tests
Build 20256: arc lint + arc unit