Use new menu constants in home menu item
ClosedPublic
Actions

Authored by chad on Jan 25 2017, 5:07 PM.

Tags

None

Referenced Files

	F15453997: D17247.diff
	Sat, Mar 29, 3:34 PM

	F15452102: D17247.diff
	Sat, Mar 29, 1:47 AM

	F15384689: D17247.id41482.diff
	Fri, Mar 14, 8:35 PM

	Unknown Object (File)
	Feb 21 2025, 3:07 PM

	Unknown Object (File)
	Feb 9 2025, 3:11 AM

	Unknown Object (File)
	Feb 9 2025, 3:11 AM

	Unknown Object (File)
	Feb 9 2025, 3:10 AM

	Unknown Object (File)
	Feb 2 2025, 2:19 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T11957: Add MenuEngine to Home

Commits

rPce09ab9b0e1a: Use new menu contsants in home menu item

Summary

Ref T11957, just lays in some minor bug fixes. Sets correct menu, removes sidebar on edit.

Test Plan

Test /menu/ on home with Admin and Normal accounts.

Diff Detail

Repository

rP Phabricator

Branch

default-menu (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15372
Build 20245: Run Core Tests
Build 20244: arc lint + arc unit

Event Timeline

chad created this revision.Jan 25 2017, 5:07 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 25 2017, 5:07 PM

Harbormaster completed remote builds in B15372: Diff 41482.Jan 25 2017, 5:08 PM

epriestley accepted this revision.Jan 25 2017, 5:10 PM

This revision is now accepted and ready to land.Jan 25 2017, 5:10 PM

chad retitled this revision from Use new menu contants in home menu item to Use new menu contsants in home menu item.Jan 25 2017, 5:21 PM

Closed by commit rPce09ab9b0e1a: Use new menu contsants in home menu item (authored by chad, committed by chad). · Explain WhyJan 25 2017, 5:22 PM

This revision was automatically updated to reflect the committed changes.

super important

Revision Contents
Changeset List

Path

Size

src/

applications/

home/

controller/

PhabricatorHomeMenuItemController.php

6 lines

Diff 41482

View Options

src/applications/home/controller/PhabricatorHomeMenuItemController.php

Use new menu constants in home menu itemClosedPublicActions