Differential D17247

Use new menu constants in home menu item
ClosedPublic
Actions

Authored by chad on Jan 25 2017, 5:07 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T11957: Add MenuEngine to Home

Commits

rPce09ab9b0e1a: Use new menu contsants in home menu item

Summary

Ref T11957, just lays in some minor bug fixes. Sets correct menu, removes sidebar on edit.

Test Plan

Test /menu/ on home with Admin and Normal accounts.

Diff Detail

Repository

rP Phabricator

Branch

default-menu (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15372
Build 20245: Run Core Tests
Build 20244: arc lint + arc unit

Event Timeline

chad created this revision.Jan 25 2017, 5:07 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 25 2017, 5:07 PM

Harbormaster completed remote builds in B15372: Diff 41482.Jan 25 2017, 5:08 PM

epriestley accepted this revision.Jan 25 2017, 5:10 PM

This revision is now accepted and ready to land.Jan 25 2017, 5:10 PM

chad retitled this revision from Use new menu contants in home menu item to Use new menu contsants in home menu item.Jan 25 2017, 5:21 PM

Closed by commit rPce09ab9b0e1a: Use new menu contsants in home menu item (authored by chad, committed by chad). · Explain WhyJan 25 2017, 5:22 PM

This revision was automatically updated to reflect the committed changes.

super important

Revision Contents
Changeset List

Path

Size

src/

applications/

home/

controller/

PhabricatorHomeMenuItemController.php

6 lines

Diff 41482

View Options

src/applications/home/controller/PhabricatorHomeMenuItemController.php

Use new menu constants in home menu itemClosedPublicActions