Page MenuHomePhabricator

Fix a JS error when adding a project card directly to a subproject from a workboard
ClosedPublic

Authored by epriestley on Jan 24 2017, 3:31 PM.
Tags
None
Referenced Files
F13318091: D17242.diff
Thu, Jun 13, 10:13 AM
F13302296: D17242.diff
Sat, Jun 8, 4:53 AM
F13280603: D17242.id41469.diff
Sun, Jun 2, 7:31 AM
F13268757: D17242.diff
Wed, May 29, 5:21 AM
F13254335: D17242.diff
Sat, May 25, 3:20 AM
F13239183: D17242.id41468.diff
Wed, May 22, 12:53 AM
F13236720: D17242.id41469.diff
Tue, May 21, 10:37 AM
F13234244: D17242.diff
Tue, May 21, 3:14 AM
Subscribers
None

Details

Summary

Fixes T12152. When creating a subproject task directly from a parent project, we can get column information back about the subproject column, which isn't visible. Just ignore this rather than trying to draw a card into a column which does not exist.

This flow (see test plan) is a little unintuitive since the card never appears on the workboard, but this class of things is probably roughly somewhere in T4900.

Test Plan
  • Create a parent project A.
  • Create subproject B.
  • On the workboard for A, select "Create Task..." from the dropdown.
  • Add tag "B" in the dialog that pops up.
  • Save the task.

Note that this flow creates a task tagged only with "B", since "A" and "B" are mutually exclusive tags.

Before patch: UI freezes (JX.Mask is never removed), JS error in console.
After patch: workflow completes. Note that card is (correctly) not visible: it's in an invisible subproject column.

Diff Detail

Repository
rP Phabricator
Branch
board1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15358
Build 20222: Run Core Tests
Build 20221: arc lint + arc unit