Page MenuHomePhabricator

Fix a JS error when adding a project card directly to a subproject from a workboard
ClosedPublic

Authored by epriestley on Jan 24 2017, 3:31 PM.
Tags
None
Referenced Files
F14055081: D17242.diff
Sat, Nov 16, 8:01 AM
F14041340: D17242.diff
Mon, Nov 11, 5:40 PM
F14028804: D17242.diff
Fri, Nov 8, 4:08 PM
F13996950: D17242.diff
Thu, Oct 24, 1:17 AM
Unknown Object (File)
Oct 10 2024, 4:20 AM
Unknown Object (File)
Oct 10 2024, 2:53 AM
Unknown Object (File)
Sep 18 2024, 9:38 AM
Unknown Object (File)
Sep 4 2024, 11:54 PM
Subscribers
None

Details

Summary

Fixes T12152. When creating a subproject task directly from a parent project, we can get column information back about the subproject column, which isn't visible. Just ignore this rather than trying to draw a card into a column which does not exist.

This flow (see test plan) is a little unintuitive since the card never appears on the workboard, but this class of things is probably roughly somewhere in T4900.

Test Plan
  • Create a parent project A.
  • Create subproject B.
  • On the workboard for A, select "Create Task..." from the dropdown.
  • Add tag "B" in the dialog that pops up.
  • Save the task.

Note that this flow creates a task tagged only with "B", since "A" and "B" are mutually exclusive tags.

Before patch: UI freezes (JX.Mask is never removed), JS error in console.
After patch: workflow completes. Note that card is (correctly) not visible: it's in an invisible subproject column.

Diff Detail

Repository
rP Phabricator
Branch
board1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15358
Build 20222: Run Core Tests
Build 20221: arc lint + arc unit