Page MenuHomePhabricator

Move Favorites and User menus to MenuBarExtensions
ClosedPublic

Authored by epriestley on Jan 21 2017, 4:32 PM.
Tags
None
Referenced Files
F13204483: D17239.diff
Wed, May 15, 12:37 AM
F13193515: D17239.id41458.diff
Sun, May 12, 2:19 PM
F13186766: D17239.diff
Sat, May 11, 3:57 AM
Unknown Object (File)
Tue, May 7, 7:39 AM
Unknown Object (File)
Fri, May 3, 5:06 AM
Unknown Object (File)
Thu, May 2, 12:46 PM
Unknown Object (File)
Mon, Apr 29, 6:24 PM
Unknown Object (File)
Thu, Apr 25, 1:08 AM
Subscribers
None

Details

Summary

Ref T12140. The major effect of this change is that uninstalling "Home" (as we do on admin.phacility.com) no longer uninstalls the user menu (which is required to access settings or log out).

This also simplifies the code a bit, by consolidating how menus are built into MenuBarExtensions instead of some in Applications and some in Extensions.

Test Plan
  • While logged in and logged out, saw main menus in the correct order.
  • Uninstalled Favorites, saw the menu vanish.
  • Uninstalled Home, still had a user menu.

Diff Detail

Repository
rP Phabricator
Branch
menu1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15348
Build 20209: Run Core Tests
Build 20208: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 21 2017, 4:38 PM
This revision was automatically updated to reflect the committed changes.