Page MenuHomePhabricator

Move Favorites and User menus to MenuBarExtensions
ClosedPublic

Authored by epriestley on Jan 21 2017, 4:32 PM.
Tags
None
Referenced Files
F17813534: D17239.id.diff
Fri, Jul 25, 8:20 PM
F17804233: D17239.id41459.diff
Fri, Jul 25, 11:09 AM
Unknown Object (File)
Jun 30 2025, 3:06 AM
Unknown Object (File)
Jun 29 2025, 8:36 AM
Unknown Object (File)
Jun 16 2025, 1:06 PM
Unknown Object (File)
Jun 16 2025, 1:03 PM
Unknown Object (File)
Jun 16 2025, 12:04 PM
Unknown Object (File)
Jun 11 2025, 3:42 AM
Subscribers
None

Details

Summary

Ref T12140. The major effect of this change is that uninstalling "Home" (as we do on admin.phacility.com) no longer uninstalls the user menu (which is required to access settings or log out).

This also simplifies the code a bit, by consolidating how menus are built into MenuBarExtensions instead of some in Applications and some in Extensions.

Test Plan
  • While logged in and logged out, saw main menus in the correct order.
  • Uninstalled Favorites, saw the menu vanish.
  • Uninstalled Home, still had a user menu.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 21 2017, 4:38 PM
This revision was automatically updated to reflect the committed changes.