Page MenuHomePhabricator

Show commit audit status in repository history tables, including merge commit lists
ClosedPublic

Authored by epriestley on Jan 19 2017, 6:53 PM.
Tags
None
Referenced Files
F15415153: D17227.id.diff
Thu, Mar 20, 4:25 AM
F15414321: D17227.diff
Thu, Mar 20, 12:10 AM
F15400285: D17227.id41435.diff
Mon, Mar 17, 10:47 AM
F15395398: D17227.diff
Sun, Mar 16, 6:42 AM
F15381341: D17227.diff
Fri, Mar 14, 7:08 AM
F15314348: D17227.diff
Thu, Mar 6, 4:50 PM
Unknown Object (File)
Mon, Mar 3, 11:39 AM
Unknown Object (File)
Tue, Feb 25, 1:35 AM
Subscribers
None

Details

Summary

Fixes T6024. Ref T12121. Currently, we show build status in commit history tables; show audit status alongside it.

Also:

  • Change the "Author/Committer" header to just "Author"; I think it's reasonably obvious what "x/y" means (if you can't guess, you can click the commit and likely figure it out) and this gives us a little more space.
  • Make the audit list look more like the corresponding list in Differential, with similar formatting.
Test Plan
  • Viewed history of a repostiory, saw audit status.
  • Viewed a merge commit, saw audit status in the list of merged commits.
  • Viewed a commit search results list.

Diff Detail

Repository
rP Phabricator
Branch
audit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15324
Build 20173: Run Core Tests
Build 20172: arc lint + arc unit