Page MenuHomePhabricator

Fix property shadowing on ActionListView after conversion to TagView
ClosedPublic

Authored by epriestley on Jan 18 2017, 7:32 PM.
Tags
None
Referenced Files
F14831231: D17223.id41424.diff
Thu, Jan 30, 12:22 AM
Unknown Object (File)
Wed, Jan 29, 6:05 AM
Unknown Object (File)
Tue, Jan 28, 7:21 AM
Unknown Object (File)
Fri, Jan 24, 6:47 PM
Unknown Object (File)
Fri, Jan 24, 6:47 PM
Unknown Object (File)
Fri, Jan 24, 6:47 PM
Unknown Object (File)
Tue, Jan 21, 3:15 PM
Unknown Object (File)
Sat, Jan 18, 7:55 AM
Subscribers
None

Details

Summary

See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an id property, and this new id property on the subclass shadows it.

Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views.

Test Plan
  • Viewed a task.
  • Made browser window narrow.
  • Clicked [= Actions] button.
  • After patch: saw a dropdown menu.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable