Page MenuHomePhabricator

Fix property shadowing on ActionListView after conversion to TagView
ClosedPublic

Authored by epriestley on Jan 18 2017, 7:32 PM.
Tags
None
Referenced Files
F14022911: D17223.id41424.diff
Wed, Nov 6, 8:59 PM
F14017509: D17223.diff
Mon, Nov 4, 6:12 PM
F13990180: D17223.id41424.diff
Tue, Oct 22, 1:49 AM
F13987453: D17223.id.diff
Mon, Oct 21, 9:33 AM
F13984127: D17223.diff
Sun, Oct 20, 11:07 AM
Unknown Object (File)
Oct 13 2024, 5:10 AM
Unknown Object (File)
Oct 13 2024, 5:09 AM
Unknown Object (File)
Oct 9 2024, 12:43 PM
Subscribers
None

Details

Summary

See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an id property, and this new id property on the subclass shadows it.

Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views.

Test Plan
  • Viewed a task.
  • Made browser window narrow.
  • Clicked [= Actions] button.
  • After patch: saw a dropdown menu.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable