Improve handle batching behavior for commit list view
ClosedPublic
Actions

Authored by epriestley on Jan 18 2017, 8:04 PM.

Tags

None

Referenced Files

	F15421831: D17225.id41433.diff
	Sat, Mar 22, 2:27 AM

	F15413245: D17225.diff
	Wed, Mar 19, 5:37 PM

	F15411076: D17225.diff
	Wed, Mar 19, 8:49 AM

	F15410977: D17225.diff
	Wed, Mar 19, 8:45 AM

	F15332294: D17225.diff
	Fri, Mar 7, 5:01 PM

	F15318388: D17225.diff
	Thu, Mar 6, 8:23 PM

	Unknown Object (File)
	Sun, Feb 23, 11:40 PM

	Unknown Object (File)
	Fri, Feb 21, 3:06 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10978: Modernize Audit

Commits

rPb8e04fe0419d: Improve handle batching behavior for commit list view

Summary

Ref T10978. Handle loads can be batched a bit more efficiently by doing them upfront.

Test Plan

Queries dropped a bit locally, but I mostly have the same autors/auditors. I'm seeing 286 queries on my account in production, so I'll check what happens with that.

Diff Detail

Repository

rP Phabricator

Branch

auditpool1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15316
Build 20162: Run Core Tests
Build 20161: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 18 2017, 8:04 PM

Harbormaster completed remote builds in B15316: Diff 41427.Jan 18 2017, 8:05 PM

chad accepted this revision.Jan 18 2017, 8:35 PM

This revision is now accepted and ready to land.Jan 18 2017, 8:35 PM

Closed by commit rPb8e04fe0419d: Improve handle batching behavior for commit list view (authored by epriestley, committed by epriestley). · Explain WhyJan 18 2017, 9:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

view/

PhabricatorAuditListView.php

37 lines

Diff 41427

View Options

src/applications/audit/view/PhabricatorAuditListView.php

Improve handle batching behavior for commit list viewClosedPublicActions