We could possibly improve this flow by giving users a modal choice ("link existing" or "create new") instead of this roadblock dialog ("stop, go do it right" or "create new"), but we'd need to put more handholding along the "link existing" flow because the user must login (and go through MFA, if applicable) before we can safely link accounts: it is not safe to link accounts just because a user knows the credential of some external account with the same email address.

This flow is rare anyway, and this roadblock mostly saves us from spending 2+ hours failing to reproduce LDAP issues in the future (T12113).

Closed by commit rP23721799fd0b: Explicitly warn the user multiple times when they try to register an external… (authored by epriestley, committed by epriestley). · Explain WhyJan 17 2017, 7:35 PM

This revision was automatically updated to reflect the committed changes.

Just for the record, this change works for me. Many thanks for quickly resolving my problem!

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

controller/

PhabricatorAuthRegisterController.php

84 lines

Diff 41400

View Options

src/applications/auth/controller/PhabricatorAuthRegisterController.php

Explicitly warn the user multiple times when they try to register an external account with an existing emailClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41400

src/applications/auth/controller/PhabricatorAuthRegisterController.php

Explicitly warn the user multiple times when they try to register an external account with an existing email
ClosedPublic
Actions

Revision Contents
Changeset List