Page MenuHomePhabricator

Fix an unusual nonterminating task graph node
ClosedPublic

Authored by epriestley on Jan 17 2017, 4:40 PM.
Tags
None
Referenced Files
F13191769: D17211.id41397.diff
Sun, May 12, 12:13 AM
F13190599: D17211.id41398.diff
Sat, May 11, 12:14 PM
F13188326: D17211.diff
Sat, May 11, 5:10 AM
F13180573: D17211.id41397.diff
Thu, May 9, 1:04 AM
Unknown Object (File)
Tue, May 7, 8:26 AM
Unknown Object (File)
Fri, May 3, 9:31 AM
Unknown Object (File)
Fri, May 3, 8:13 AM
Unknown Object (File)
Tue, Apr 30, 1:46 AM
Subscribers
None

Details

Summary

Fixes T12114. There were a couple of bugs here:

  • We could draw too many joining lines if a node had a parent with multiple descendants.
  • We could incorrectly ignore columns because of an unset().

I think this fixes both things without collateral damage. This whole thing is a little hard to understand/debug and has grown beyond its original scope, so I'll probably rewrite it if there are more issues.

Test Plan
  • Unit tests.
  • My local repro is clean now:

Screen Shot 2017-01-17 at 8.36.55 AM.png (349×262 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 17 2017, 4:42 PM
This revision was automatically updated to reflect the committed changes.