Page MenuHomePhabricator

Fix an unusual nonterminating task graph node
ClosedPublic

Authored by epriestley on Jan 17 2017, 4:40 PM.
Tags
None
Referenced Files
F13224427: D17211.id41398.diff
Sun, May 19, 8:31 AM
F13222441: D17211.diff
Sun, May 19, 3:40 AM
F13205035: D17211.diff
Wed, May 15, 1:23 AM
F13201314: D17211.id.diff
Tue, May 14, 10:38 AM
F13191769: D17211.id41397.diff
Sun, May 12, 12:13 AM
F13190599: D17211.id41398.diff
Sat, May 11, 12:14 PM
F13188326: D17211.diff
Sat, May 11, 5:10 AM
F13180573: D17211.id41397.diff
Thu, May 9, 1:04 AM
Subscribers
None

Details

Summary

Fixes T12114. There were a couple of bugs here:

  • We could draw too many joining lines if a node had a parent with multiple descendants.
  • We could incorrectly ignore columns because of an unset().

I think this fixes both things without collateral damage. This whole thing is a little hard to understand/debug and has grown beyond its original scope, so I'll probably rewrite it if there are more issues.

Test Plan
  • Unit tests.
  • My local repro is clean now:

Screen Shot 2017-01-17 at 8.36.55 AM.png (349×262 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 17 2017, 4:42 PM
This revision was automatically updated to reflect the committed changes.