Page MenuHomePhabricator

Fix an unusual nonterminating task graph node
ClosedPublic

Authored by epriestley on Jan 17 2017, 4:40 PM.
Tags
None
Referenced Files
F15415528: D17211.diff
Thu, Mar 20, 6:29 AM
F15403291: D17211.diff
Tue, Mar 18, 2:38 AM
F15391823: D17211.id41398.diff
Sat, Mar 15, 11:49 AM
F15379721: D17211.id41397.diff
Thu, Mar 13, 10:59 PM
Unknown Object (File)
Fri, Feb 21, 3:05 PM
Unknown Object (File)
Feb 5 2025, 3:24 AM
Unknown Object (File)
Feb 5 2025, 3:23 AM
Unknown Object (File)
Feb 5 2025, 3:23 AM
Subscribers
None

Details

Summary

Fixes T12114. There were a couple of bugs here:

  • We could draw too many joining lines if a node had a parent with multiple descendants.
  • We could incorrectly ignore columns because of an unset().

I think this fixes both things without collateral damage. This whole thing is a little hard to understand/debug and has grown beyond its original scope, so I'll probably rewrite it if there are more issues.

Test Plan
  • Unit tests.
  • My local repro is clean now:

Screen Shot 2017-01-17 at 8.36.55 AM.png (349×262 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Branch
graph1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15286
Build 20114: Run Core Tests
Build 20113: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 17 2017, 4:42 PM
This revision was automatically updated to reflect the committed changes.