Page MenuHomePhabricator

Hide dropdown menus when users click workflow items
ClosedPublic

Authored by epriestley on Jan 16 2017, 9:33 PM.
Tags
None
Referenced Files
F14062089: D17210.diff
Mon, Nov 18, 10:28 AM
F14057517: D17210.diff
Sun, Nov 17, 4:11 AM
F14030100: D17210.id41392.diff
Sat, Nov 9, 12:02 AM
F14011518: D17210.diff
Fri, Nov 1, 2:39 AM
F13990118: D17210.id41393.diff
Tue, Oct 22, 1:21 AM
F13968026: D17210.id41392.diff
Oct 16 2024, 6:00 PM
Unknown Object (File)
Oct 9 2024, 1:54 PM
Unknown Object (File)
Sep 15 2024, 5:38 AM
Subscribers
None

Details

Summary

In D16157, dropdown menus got an overly-broad check for not closing when an item is clicked.

Specifically, we don't want to close the menu if the item is really opening a submenu, like "Edit Related Objects..." does on mobile.

The check for this is too broad, and also doesn't close the menu if the item has workflow.

Instead, use a narrower check.

Test Plan
  • Menu still stays open when toggling submenus like "Edit Related Objects".
  • Menu now closes properly when using workflow items like "Edit Comment" or "Remove Comment".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable