Page MenuHomePhabricator

Remove some remnants of the old ways commit mesage fields worked from Differential
ClosedPublic

Authored by epriestley on Jan 13 2017, 11:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 8:44 AM
Unknown Object (File)
Mon, Nov 25, 2:04 AM
Unknown Object (File)
Mon, Nov 25, 1:39 AM
Unknown Object (File)
Sun, Nov 24, 5:50 AM
Unknown Object (File)
Sat, Nov 23, 2:14 AM
Unknown Object (File)
Mon, Nov 18, 11:57 PM
Unknown Object (File)
Fri, Nov 1, 6:01 AM
Unknown Object (File)
Oct 27 2024, 3:58 AM
Subscribers
None

Details

Summary

Ref T11114. Ref T12085. I missed a few pieces of cleanup when moving all this stuff over.

In particular, load all fields which use Custom Field storage before doing commit-message-related stuff, instead of just the ones that claim they appear on commit messages.

Test Plan

Edited revisions and made API calls without apparent issues. See followup on T12085, shortly.

Diff Detail

Repository
rP Phabricator
Branch
rev3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15262
Build 20068: Run Core Tests
Build 20067: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 13 2017, 11:21 PM
  • Get rid of slightly more cruft.
  • Don't send my hilarious "you will be fired" suggestion upstream.

I'm only like 95% sure all this code was actually completely unused, so yell if you catch anything weird. It's supposed to be unused, though.

This revision was automatically updated to reflect the committed changes.