Page MenuHomePhabricator
Differential D17207

Remove some remnants of the old ways commit mesage fields worked from Differential
ClosedPublic
Actions

Authored by epriestley on Jan 13 2017, 11:18 PM.
Tags
None
Referenced Files
F13187279: D17207.diff
Sat, May 11, 4:26 AM
F13178280: D17207.diff
Wed, May 8, 8:19 PM
Unknown Object (File)
Tue, May 7, 7:33 AM
Unknown Object (File)
Tue, May 7, 2:19 AM
Unknown Object (File)
Fri, May 3, 6:51 AM
Unknown Object (File)
Fri, May 3, 12:29 AM
Unknown Object (File)
Thu, May 2, 2:41 AM
Unknown Object (File)
Mon, Apr 29, 3:02 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages
Commits
rP62cf4e6b95ab: Remove some remnants of the old ways commit mesage fields worked from…
Summary

Ref T11114. Ref T12085. I missed a few pieces of cleanup when moving all this stuff over.

In particular, load all fields which use Custom Field storage before doing commit-message-related stuff, instead of just the ones that claim they appear on commit messages.

Test Plan

Edited revisions and made API calls without apparent issues. See followup on T12085, shortly.

Diff Detail

Repository
rP Phabricator
Branch
rev3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15261
Build 20066: Run Core Tests
Build 20065: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 13 2017, 11:18 PM
Harbormaster completed remote builds in B15261: Diff 41371.Jan 13 2017, 11:19 PM
chad accepted this revision.Jan 13 2017, 11:21 PM
This revision is now accepted and ready to land.Jan 13 2017, 11:21 PM
epriestley updated this revision to Diff 41372.Jan 13 2017, 11:25 PM
  • Get rid of slightly more cruft.
Harbormaster completed remote builds in B15262: Diff 41372.Jan 13 2017, 11:26 PM
epriestley updated this revision to Diff 41373.Jan 13 2017, 11:27 PM
  • Don't send my hilarious "you will be fired" suggestion upstream.
Harbormaster completed remote builds in B15263: Diff 41373.Jan 13 2017, 11:28 PM
epriestley added a comment.Jan 13 2017, 11:28 PM

I'm only like 95% sure all this code was actually completely unused, so yell if you catch anything weird. It's supposed to be unused, though.

Closed by commit rP62cf4e6b95ab: Remove some remnants of the old ways commit mesage fields worked from… (authored by epriestley, committed by epriestley). · Explain WhyJan 13 2017, 11:29 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Jan 13 2017, 11:31 PM

I have my own fires

epriestley mentioned this in T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.Jan 13 2017, 11:31 PM
epriestley mentioned this in T12084: `differential.updaterevision` conduit method no longer updates custom fields.Jan 16 2017, 3:46 PM

Revision Contents
Changeset List

Diff 41371

View Options

src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php

Loading...
View Options

src/applications/differential/customfield/DifferentialAuditorsField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialBlameRevisionField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialCustomField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialJIRAIssuesField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialRevertPlanField.php

Loading...
View Options

src/applications/differential/field/DifferentialCommitMessageCustomField.php

Loading...
Phabricator · Built by Phacility