Page MenuHomePhabricator

Improve commit audit status icons
ClosedPublic

Authored by epriestley on Jan 13 2017, 12:33 AM.
Tags
None
Referenced Files
F13292746: D17203.id41363.diff
Wed, Jun 5, 5:01 AM
F13292273: D17203.id41364.diff
Wed, Jun 5, 3:08 AM
F13292023: D17203.id41363.diff
Wed, Jun 5, 1:09 AM
F13272791: D17203.diff
Thu, May 30, 9:20 PM
F13228012: D17203.id.diff
Mon, May 20, 6:15 AM
F13200835: D17203.id41363.diff
May 14 2024, 4:07 AM
F13199577: D17203.id41364.diff
May 13 2024, 3:59 PM
Unknown Object (File)
May 3 2024, 8:44 AM
Subscribers
None

Details

Summary

Ref T9482. These may need a little more work (feel free to shoot me a counter-diff) but try to:

  • Never use only color to distinguish between states (for colorblind, etc users).
  • Give the "nothing needs to be done" state a more obvious "okay" icon (instead of a question mark).
Test Plan

Looked at some linked commits in Maniphest, the icons made a bit more sense?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 13 2017, 12:34 AM
This revision was automatically updated to reflect the committed changes.