Page MenuHomePhabricator

Improve commit audit status icons
ClosedPublic

Authored by epriestley on Jan 13 2017, 12:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 1:46 PM
Unknown Object (File)
Oct 18 2024, 10:17 AM
Unknown Object (File)
Oct 18 2024, 6:49 AM
Unknown Object (File)
Oct 16 2024, 3:05 AM
Unknown Object (File)
Oct 12 2024, 11:01 PM
Unknown Object (File)
Oct 6 2024, 5:57 AM
Unknown Object (File)
Sep 15 2024, 3:38 PM
Unknown Object (File)
Sep 5 2024, 10:37 PM
Subscribers
None

Details

Summary

Ref T9482. These may need a little more work (feel free to shoot me a counter-diff) but try to:

  • Never use only color to distinguish between states (for colorblind, etc users).
  • Give the "nothing needs to be done" state a more obvious "okay" icon (instead of a question mark).
Test Plan

Looked at some linked commits in Maniphest, the icons made a bit more sense?

Diff Detail

Repository
rP Phabricator
Branch
commit20
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15251
Build 20052: Run Core Tests
Build 20051: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 13 2017, 12:34 AM
This revision was automatically updated to reflect the committed changes.