` requests explicitly 404
ClosedPublic
Actions

Authored by epriestley on Jan 9 2017, 8:09 PM.

Details

Reviewers

chad

Commits

rP0e1388340c5a: Make profile menu `/edit/` requests explicitly 404

Summary

See D17160. Previously, the /edit/ route was never linked, but fataled when accessed. Make it 404 instead.

Also, fix an issue where editing "Application" menu items would fail because they didn't have a viewer.

Test Plan

Hit /edit/, got a 404.
Edited an "Application" item.
Moved, added, deleted, and edited other items.

Diff Detail

Repository

rP Phabricator

Branch

edit404

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15164
Build 19921: Run Core Tests
Build 19920: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 9 2017, 8:09 PM

Harbormaster completed remote builds in B15164: Diff 41277.Jan 9 2017, 8:10 PM

chad accepted this revision.Jan 9 2017, 8:12 PM

This revision is now accepted and ready to land.Jan 9 2017, 8:12 PM

Closed by commit rP0e1388340c5a: Make profile menu `/edit/` requests explicitly 404 (authored by epriestley, committed by epriestley). · Explain WhyJan 9 2017, 8:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorProfileMenuEngine.php

10 lines

query/

PhabricatorProfileMenuItemConfigurationQuery.php

1 line

Diff 41277

View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php