Page MenuHomePhabricator

Remove extra container tag on HandleListViews rendering from ModularTransactions in text mode
ClosedPublic

Authored by epriestley on Jan 9 2017, 4:19 PM.
Tags
None
Referenced Files
F19512851: D17162.id41273.diff
Tue, Jan 13, 3:45 AM
F19154519: D17162.id41273.diff
Dec 11 2025, 3:50 PM
F19147114: D17162.id41273.diff
Dec 10 2025, 3:59 PM
F19079761: D17162.id.diff
Dec 1 2025, 10:40 PM
F19034838: D17162.id.diff
Nov 25 2025, 3:08 PM
F19029254: D17162.diff
Nov 24 2025, 5:17 PM
F19016981: D17162.diff
Nov 23 2025, 6:19 AM
F19016966: D17162.diff
Nov 23 2025, 6:11 AM
Subscribers
None

Details

Summary

Fixes T12082. Ref T11114. When modular transaction render a handle list, they use HandleListView, which has a text mode.

However, the HandleListView is a TagView, and currently TagViews always render a tag of some kind. Allow them to return null to decline to render any tag.

Test Plan
  • Added a pile of debugging stuff to ApplicationTransactionEditor to throw during mail generation.
  • Added a reviewer to a revision.
  • Used bin/worker execute --id ... to hit the mail generation repeatedly.
  • Before patch: mail generated with a <span>, even in text mode.
  • After patch: clean mail generation.

Diff Detail

Repository
rP Phabricator
Branch
literal2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/phid/view/PHUIHandleListView.php:44XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 15157
Build 19910: Run Core Tests
Build 19909: arc lint + arc unit