Page MenuHomePhabricator
Differential D17141

Bring up contrast on light green / red diffs
ClosedPublic
Actions

Authored by chad on Jan 4 2017, 10:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 11:59 AM
Unknown Object (File)
Thu, Apr 25, 1:24 AM
Unknown Object (File)
Wed, Apr 24, 6:17 AM
Unknown Object (File)
Fri, Apr 19, 6:01 PM
Unknown Object (File)
Thu, Apr 11, 8:54 AM
Unknown Object (File)
Sun, Apr 7, 4:28 PM
Unknown Object (File)
Sat, Apr 6, 8:02 PM
Unknown Object (File)
Sat, Apr 6, 2:20 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP96fbf37dcc11: Bring up contrast on light green / red diffs
Summary

Minor color saturation here, ideal for low quality monitors.

Test Plan

Review new colors in various scenarios.

pasted_file (880×2 px, 163 KB)

Diff Detail

Repository
rP Phabricator
Branch
colors-2 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15108
Build 19836: Run Core Tests
Build 19835: arc lint + arc unit

Event Timeline

chad created this revision.Jan 4 2017, 10:37 PM
Herald added a subscriber: Korvin. · View Herald TranscriptJan 4 2017, 10:37 PM
epriestley accepted this revision.Jan 4 2017, 10:38 PM
epriestley edited edge metadata.

thx u

Harbormaster completed remote builds in B15106: Diff 41221.Jan 4 2017, 10:38 PM
chad planned changes to this revision.Jan 4 2017, 10:39 PM

actually going to spend some more time on this.

chad updated this revision to Diff 41223.Jan 4 2017, 11:06 PM
  • Stronger color hinting, but only on side of diffs
Harbormaster completed remote builds in B15108: Diff 41223.Jan 4 2017, 11:06 PM
chad edited the test plan for this revision. (Show Details)Jan 4 2017, 11:07 PM
Harbormaster completed remote builds in B15108: Diff 41223.Jan 4 2017, 11:07 PM
epriestley accepted this revision.Jan 4 2017, 11:07 PM
This revision is now accepted and ready to land.Jan 4 2017, 11:07 PM
Closed by commit rP96fbf37dcc11: Bring up contrast on light green / red diffs (authored by chad, committed by chad). · Explain WhyJan 4 2017, 11:18 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Jan 4 2017, 11:24 PM

let me know

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
applications/
differential/
render/
20 lines
4 lines
webroot/
rsrc/
css/
application/
differential/
10 lines

Diff 41223

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
Phabricator · Built by Phacility