Differential D17141

Bring up contrast on light green / red diffs
ClosedPublic
Actions

Authored by chad on Jan 4 2017, 10:37 PM.

Details

Reviewers

epriestley

Commits

rP96fbf37dcc11: Bring up contrast on light green / red diffs

Summary

Minor color saturation here, ideal for low quality monitors.

Test Plan

Review new colors in various scenarios.

Diff Detail

Repository

rP Phabricator

Branch

colors-2 (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15106
Build 19832: Run Core Tests
Build 19831: arc lint + arc unit

Event Timeline

chad created this revision.Jan 4 2017, 10:37 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 4 2017, 10:37 PM

thx u

Harbormaster completed remote builds in B15106: Diff 41221.Jan 4 2017, 10:38 PM

actually going to spend some more time on this.

Stronger color hinting, but only on side of diffs

Harbormaster completed remote builds in B15108: Diff 41223.Jan 4 2017, 11:06 PM

chad edited the test plan for this revision. (Show Details)Jan 4 2017, 11:07 PM

Harbormaster completed remote builds in B15108: Diff 41223.Jan 4 2017, 11:07 PM

epriestley accepted this revision.Jan 4 2017, 11:07 PM

This revision is now accepted and ready to land.Jan 4 2017, 11:07 PM

Closed by commit rP96fbf37dcc11: Bring up contrast on light green / red diffs (authored by chad, committed by chad). · Explain WhyJan 4 2017, 11:18 PM

This revision was automatically updated to reflect the committed changes.

let me know

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

4 lines

Diff 41221

View Options

resources/celerity/map.php