Built similar to Projects, allows setting of a Dashboard to MenuItem.
Details
Details
- Reviewers
epriestley - Commits
- rP5e6afa97bc45: Add a Dashboard MenuItem
Add a dashboard with and without a name / icon to a Project.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dashboard-menuitem (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 14998 Build 19667: Run Core Tests Build 19666: arc lint + arc unit
Event Timeline
Comment Actions
In both this and projects, I wonder if we should flip the "name" and "thing" fields, so they primary/required field is on top? Although maybe you're usually going to want to rename dashboards.
Comment Actions
You could setPlaceHolder(pht('This is an optional field which you do not need to fill out if you would prefer not to fill it out')) too, I think.