Page MenuHomePhabricator
Differential D17092

Add a Dashboard MenuItem
ClosedPublic
Actions

Authored by chad on Dec 16 2016, 9:03 PM.
Tags
None
Referenced Files
F14351457: D17092.diff
Thu, Dec 19, 7:44 AM
Unknown Object (File)
Wed, Dec 11, 3:53 AM
Unknown Object (File)
Tue, Dec 10, 6:37 PM
Unknown Object (File)
Mon, Dec 9, 4:06 PM
Unknown Object (File)
Mon, Dec 9, 5:57 AM
Unknown Object (File)
Mon, Dec 9, 5:57 AM
Unknown Object (File)
Mon, Dec 9, 5:56 AM
Unknown Object (File)
Mon, Dec 9, 5:51 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP5e6afa97bc45: Add a Dashboard MenuItem
Summary

Built similar to Projects, allows setting of a Dashboard to MenuItem.

Test Plan

Add a dashboard with and without a name / icon to a Project.

Diff Detail

Repository
rP Phabricator
Branch
dashboard-menuitem (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14998
Build 19667: Run Core Tests
Build 19666: arc lint + arc unit

Event Timeline

chad created this revision.Dec 16 2016, 9:03 PM
Herald added a subscriber: Korvin. · View Herald TranscriptDec 16 2016, 9:03 PM
chad added a comment.Dec 16 2016, 9:09 PM

This works really well, if it ajaxed in, we'd have Project Dashboards.

epriestley accepted this revision.Dec 16 2016, 9:13 PM
epriestley edited edge metadata.

In both this and projects, I wonder if we should flip the "name" and "thing" fields, so they primary/required field is on top? Although maybe you're usually going to want to rename dashboards.

This revision is now accepted and ready to land.Dec 16 2016, 9:13 PM
chad added a comment.Dec 16 2016, 9:24 PM

I could maybe call the field "Name (optional):"

epriestley added a comment.Dec 16 2016, 9:28 PM

You could setPlaceHolder(pht('This is an optional field which you do not need to fill out if you would prefer not to fill it out')) too, I think.

Closed by commit rP5e6afa97bc45: Add a Dashboard MenuItem (authored by chad, committed by chad). · Explain WhyDec 16 2016, 9:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
dashboard/
storage/
4 lines
search/
menuitem/
112 lines

Diff 41109

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboard.php

Loading...
View Options

src/applications/search/menuitem/PhabricatorDashboardProfileMenuItem.php

Loading...
Phabricator · Built by Phacility