Page MenuHomePhabricator
Differential D17091

Rename Differenital "EditPro" controller back to "Edit"
ClosedPublic
Actions

Authored by epriestley on Dec 16 2016, 8:33 PM.
Tags
None
Referenced Files
F14379510: D17091.id41108.diff
Sat, Dec 21, 2:55 AM
Unknown Object (File)
Thu, Dec 19, 4:09 AM
Unknown Object (File)
Sun, Dec 15, 11:31 PM
Unknown Object (File)
Fri, Dec 13, 4:38 PM
Unknown Object (File)
Thu, Dec 12, 7:07 PM
Unknown Object (File)
Mon, Dec 9, 5:57 AM
Unknown Object (File)
Mon, Dec 9, 5:57 AM
Unknown Object (File)
Mon, Dec 9, 5:56 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP28d74ae572f3: Rename Differenital "EditPro" controller back to "Edit"
Summary

Ref T11114. We seem to be in reasonable shape here and I don't think anything needs to revert, so rename this back to boring old "edit".

Test Plan

Created, updated, edited a revision via web UI.

Diff Detail

Repository
rP Phabricator
Branch
diff42
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14997
Build 19665: Run Core Tests
Build 19664: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 16 2016, 8:33 PM
epriestley added a comment.Dec 16 2016, 8:37 PM

what is going on here

why is this working properly

iiam

chad accepted this revision.Dec 16 2016, 8:37 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 8:37 PM
Closed by commit rP28d74ae572f3: Rename Differenital "EditPro" controller back to "Edit" (authored by epriestley, committed by epriestley). · Explain WhyDec 16 2016, 9:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
differential/
application/
6 lines
controller/
DifferentialRevisionEditController.php
DifferentialRevisionEditProController.php
2 lines
2 lines

Diff 41108

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/application/PhabricatorDifferentialApplication.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionEditController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionEditProController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
Phabricator · Built by Phacility