Page MenuHomePhabricator
Differential D17088

Simplify "Tasks" field in Differential
ClosedPublic
Actions

Authored by epriestley on Dec 16 2016, 6:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 1:46 PM
Unknown Object (File)
Wed, Dec 11, 7:45 PM
Unknown Object (File)
Mon, Dec 9, 6:33 AM
Unknown Object (File)
Mon, Dec 9, 6:33 AM
Unknown Object (File)
Mon, Dec 9, 6:30 AM
Unknown Object (File)
Mon, Dec 9, 6:14 AM
Unknown Object (File)
Thu, Dec 5, 2:23 AM
Unknown Object (File)
Tue, Dec 3, 6:25 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP60f41b87e9d0: Simplify "Tasks" field in Differential
Summary

Ref T11114. Keep UI, throw everything else away.

Includes an imperfect-but-not-too-awful fix to keep the field actually working.

Test Plan

Edited tasks from CLI.

Diff Detail

Repository
rP Phabricator
Branch
diff40
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14969
Build 19634: Run Core Tests
Build 19633: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 41080.Dec 16 2016, 6:01 PM
epriestley retitled this revision from to Simplify "Tasks" field in Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11114: Move Differential to EditEngine.
chad accepted this revision.Dec 16 2016, 6:13 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 6:13 PM
Closed by commit rP60f41b87e9d0: Simplify "Tasks" field in Differential (authored by epriestley, committed by epriestley). · Explain WhyDec 16 2016, 6:26 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.Jan 9 2017, 5:32 PM

Revision Contents
Changeset List

Diff 41080

View Options

src/applications/differential/customfield/DifferentialManiphestTasksField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialProjectReviewersField.php

Loading...
View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Loading...
View Options

src/applications/differential/field/DifferentialCommitMessageField.php

Loading...
View Options

src/applications/differential/field/DifferentialTasksCommitMessageField.php

Loading...
Phabricator · Built by Phacility