Page MenuHomePhabricator
Differential D17086

Simplify Differential "Reviewers" field
ClosedPublic
Actions

Authored by epriestley on Dec 16 2016, 5:49 PM.
Tags
None
Referenced Files
F14351959: D17086.diff
Thu, Dec 19, 11:59 AM
Unknown Object (File)
Mon, Dec 9, 4:37 PM
Unknown Object (File)
Mon, Dec 9, 6:33 AM
Unknown Object (File)
Mon, Dec 9, 6:33 AM
Unknown Object (File)
Mon, Dec 9, 6:30 AM
Unknown Object (File)
Mon, Dec 9, 6:14 AM
Unknown Object (File)
Thu, Dec 5, 2:22 AM
Unknown Object (File)
Nov 19 2024, 9:10 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP18debbfdb4f4: Simplify Differential "Reviewers" field
Summary

Ref T11114. Keep rendering and mail, toss the rest.

Test Plan

Edited and viewed reviewers.

Diff Detail

Repository
rP Phabricator
Branch
diff38
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14967
Build 19630: Run Core Tests
Build 19629: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 41078.Dec 16 2016, 5:49 PM
epriestley retitled this revision from to Simplify Differential "Reviewers" field.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11114: Move Differential to EditEngine.
chad accepted this revision.Dec 16 2016, 5:50 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 5:50 PM
Closed by commit rP18debbfdb4f4: Simplify Differential "Reviewers" field (authored by epriestley, committed by epriestley). · Explain WhyDec 16 2016, 6:25 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.Jan 9 2017, 5:32 PM

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
customfield/
239 lines
storage/
3 lines
transactions/
storage/
15 lines

Diff 41078

View Options

src/applications/differential/customfield/DifferentialReviewersField.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility