Page MenuHomePhabricator
Differential D17080

Remove "Revision ID" custom field
ClosedPublic
Actions

Authored by epriestley on Dec 16 2016, 5:15 PM.
Tags
None
Referenced Files
F14394142: D17080.diff
Sun, Dec 22, 1:41 AM
Unknown Object (File)
Fri, Dec 20, 6:15 PM
Unknown Object (File)
Mon, Dec 9, 6:32 AM
Unknown Object (File)
Mon, Dec 9, 6:32 AM
Unknown Object (File)
Mon, Dec 9, 6:29 AM
Unknown Object (File)
Mon, Dec 9, 6:14 AM
Unknown Object (File)
Sat, Dec 7, 1:32 PM
Unknown Object (File)
Fri, Dec 6, 11:58 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP3893b5f1a5fa: Remove "Revision ID" custom field
Summary

Ref T11114. Obsoleted by DifferentialRevisionIDCommitMessageField.

Test Plan
  • Grepped for removed class.
  • Created a new revision, verified that the amended message included a proper revision ID.

Diff Detail

Repository
rP Phabricator
Branch
diff32
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14961
Build 19618: Run Core Tests
Build 19617: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 41072.Dec 16 2016, 5:15 PM
epriestley retitled this revision from to Remove "Revision ID" custom field.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11114: Move Differential to EditEngine.
chad accepted this revision.Dec 16 2016, 5:21 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 5:21 PM
Closed by commit rP3893b5f1a5fa: Remove "Revision ID" custom field (authored by epriestley, committed by epriestley). · Explain WhyDec 16 2016, 6:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41072

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/conduit/DifferentialParseCommitMessageConduitAPIMethod.php

Loading...
View Options

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Loading...
View Options

src/applications/differential/customfield/DifferentialRevisionIDField.php

Loading...
Phabricator · Built by Phacility