Page MenuHomePhabricator

Make stored custom fields work with v3 EditEngine API
ClosedPublic

Authored by epriestley on Dec 16 2016, 2:19 PM.
Tags
None
Referenced Files
F19134778: D17068.id.diff
Dec 10 2025, 8:44 AM
F19104515: D17068.id41056.diff
Dec 5 2025, 2:28 PM
F19071076: D17068.id41056.diff
Nov 30 2025, 6:24 PM
F19060485: D17068.id41084.diff
Nov 29 2025, 9:24 AM
F19055568: D17068.id41084.diff
Nov 28 2025, 5:43 PM
F19051762: D17068.id.diff
Nov 28 2025, 1:57 AM
F18876126: D17068.diff
Nov 5 2025, 9:48 PM
F18863118: D17068.diff
Nov 2 2025, 10:01 PM
Subscribers
None

Details

Summary

Ref T11114. This makes the unusual stored custom fields ("Blame Rev", "Revert Plan", etc) work somewhat correctly (?) with EditEngine.

Test Plan
  • Created, updated and edited revisions with unusual stored custom fields like "Blame Rev".
  • Observed that these fields now populate in "differential.revision.edit" when available.

Diff Detail

Repository
rP Phabricator
Branch
diff20
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/customfield/DifferentialCustomField.php:23XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14945
Build 19588: Run Core Tests
Build 19587: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make stored custom fields work with v3 EditEngine API.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 3:21 PM
This revision was automatically updated to reflect the committed changes.